[ntuple] move RColumnElement out of anonymous namespace #16907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
requested review from
hahnjo,
pcanal,
dpiparo,
vepadulano and
enirolf
jblomer
reviewed
Nov 12, 2024
silverweed
force-pushed
the
ntuple_col_no_anon
branch
from
f271f79
to
9ac7bce
Compare
pcanal
reviewed
Nov 12, 2024
| @@ -313,8 +313,7 @@ inline void CastZigzagSplitUnpack(void *destination, const void *source, std::si | |||
| } | |||
| } // namespace | |||
|
|
|||
| // anonymous namespace because these definitions are not meant to be exported. | |||
| namespace { | |||
| namespace ROOT::Experimental::Internal { | |||
There was a problem hiding this comment.
Indeed, it is quite unusual to have an anonymous namespace in a header file. I guess it would result in any symbol/function defined in there to be actually declared/defined multiple times (one per source file that include this header) with different actual names
There was a problem hiding this comment.
We should probably also review line 57 of this file and
bindings/pyroot/cppyy/CPyCppyy/src/DeclareConverters.h:namespace {
bindings/pyroot/cppyy/CPyCppyy/src/DeclareExecutors.h:namespace {
bindings/pyroot/cppyy/cppyy/test/stltypes.h:namespace {
io/io/test/io_test.hxx:namespace {
math/mathcore/src/MixMaxEngineImpl.h:namespace {
tree/ntuple/v7/test/SimpleCollectionProxy.hxx:namespace {
Test Results 19 files 19 suites 3d 22h 48m 20s ⏱️ Results for commit c826c8b. ♻️ This comment has been updated with latest results. |
Those functions need to be defined static to avoid violating ODR in the ntuple_endian, that includes the file while changing the endianness, ending up with a different definition of those functions.
silverweed
force-pushed
the
ntuple_col_no_anon
branch
from
9ac7bce
to
c826c8b
Compare
|
#16923 is an alternative that reduces the includes of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid spurious warnings by some compilers, such as: